AAE-29424 Screens #10499

tomaszhanaj · 2024-12-16T13:06:52Z

Please check if the PR fulfills these requirements

The commit message follows our guidelines

Tests for the changes have been added (for bug fixes / features)

Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

Bugfix

Feature

Code style update (formatting, local variables)

Refactoring (no functional changes, no api changes)

Build related changes

Documentation

Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?
https://hyland.atlassian.net/browse/AAE-29424

Does this PR introduce a breaking change? (check one with "x")

Yes

No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
Component TaskFormCloudComponent has changed and now is used in:
libs/content-ee/process-services-cloud-extension/src/lib/features/task-details/components/task-details-cloud-ext/task-details-cloud-ext.component.html
and needs to be replaced with newly added UserTaskCloudComponent

BSekula · 2024-12-16T13:26:24Z

lib/process-services-cloud/src/lib/screen/components/screen-cloud/screen-cloud.component.html

@@ -0,0 +1,3 @@
+<div>


is this parent div required?

BSekula · 2024-12-16T14:14:01Z

lib/process-services-cloud/src/lib/screen/components/screen-cloud/screen-cloud.component.ts

+    ngOnInit() {
+        if (this.screenId) {
+            this.screenComponent = { type: this.screenId };
+            const componentType = this.screenRenderingService.resolveComponentType(this.screenComponent);


Suggested change

const componentType = this.screenRenderingService.resolveComponentType(this.screenComponent);

const componentType = this.screenRenderingService.resolveComponentType({ type: this.screenId });

instead of this.screenComponent = { type: this.screenId };

not sure about it because we lose details about type, that probably should be here but maybe YAGNI. updated

BSekula · 2024-12-16T14:15:22Z

lib/process-services-cloud/src/lib/services/screen-rendering.service.ts

+ */
+
+import { Injectable } from '@angular/core';
+import { DynamicComponentMapper } from '../../../../core/src/lib/common/services/dynamic-component-mapper.service';


Import should be from `@alfresco/core, not relative path

BSekula · 2024-12-16T14:15:36Z

...vices-cloud/src/lib/task/task-form/components/task-form-cloud/task-form-cloud.component.html

@@ -0,0 +1,37 @@
+<div class="adf-task-form-cloud-container" >
+    <adf-cloud-form #adfCloudForm


can we fix indentations?

BSekula · 2024-12-16T14:17:36Z

...lib/task/task-form/components/user-task-cloud-buttons/user-task-cloud-buttons.component.html

+    mat-button
+    *ngIf="showCancelButton"
+    id="adf-cloud-cancel-task"
+    (click)="onCancelClick()">


Suggested change

(click)="onCancelClick()">

(click)="onCancelClick()"

>

{{'ADF_CLOUD_TASK_FORM.EMPTY_FORM.BUTTONS.CANCEL' | translate}}

wdyt?

With this one, it is hard to see when button tag ends

(click)="onCancelClick()"> {{'ADF_CLOUD_TASK_FORM.EMPTY_FORM.BUTTONS.CANCEL' | translate}}

ps. can we add *ngIfs at the top of the buttons parameter lists?

BSekula · 2024-12-16T14:21:33Z

...vices-cloud/src/lib/task/task-form/components/user-task-cloud/user-task-cloud.component.html

+    </div>
+</div>
+
+


Suggested change

BSekula · 2024-12-16T14:21:49Z

...vices-cloud/src/lib/task/task-form/components/user-task-cloud/user-task-cloud.component.html

+                            (error)="onError($event)"
+                            color="primary"
+                            id="adf-form-complete"
+                            >


Suggested change

>

>

BSekula · 2024-12-16T14:22:20Z

...ervices-cloud/src/lib/task/task-form/components/user-task-cloud/user-task-cloud.component.ts

+    None: ''
+} as const;
+
+type TaskTypesType = (typeof TaskTypes)[keyof typeof TaskTypes];


Suggested change

type TaskTypesType = (typeof TaskTypes)[keyof typeof TaskTypes];

type TaskTypesType = typeof TaskTypes[keyof typeof TaskTypes];

wdyt?

BSekula · 2024-12-16T14:23:19Z

...ervices-cloud/src/lib/task/task-form/components/user-task-cloud/user-task-cloud.component.ts

+        return !this.readOnly && this.taskCloudService.canUnclaimTask(this.taskDetails) && this.hasCandidateUsersOrGroups();
+    }
+
+    getTaskType() {


Suggested change

getTaskType() {

getTaskType(): void {

Can we add type also for others?

BSekula · 2024-12-16T14:23:45Z

...ervices-cloud/src/lib/task/task-form/components/user-task-cloud/user-task-cloud.component.ts

+        }
+    }
+
+    ngOnInit() {


can we move live hook to the top?

BSekula · 2024-12-16T15:08:38Z

As discussed, can we change names to:

adf-cloud-user-task UserTaskCloudComponent
    adf-cloud-task-form TaskFormCloudComponent
    adf-cloud-task-screen TaskScreenCloudComponent

sonarqubecloud · 2024-12-18T12:21:59Z

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.5% Duplication on New Code

See analysis details on SonarQube Cloud

tomaszhanaj requested review from eromano, popovicsandras and DenysVuika as code owners December 16, 2024 13:06

BSekula reviewed Dec 16, 2024

View reviewed changes

BSekula approved these changes Dec 18, 2024

View reviewed changes

tomaszhanaj added 7 commits December 18, 2024 13:01

poc

41bbf0b

updated unit tests

f8d4e2c

removed obsolete service, updated interface

b3569c9

passing data to created component, removed obsolete files

c57237e

[AAE-29424] applied pr comments

fdf9281

[AAE-29424] updated import to avoid circular dependency error

69afedd

[AAE-29424] updated styles to avoid visual bug

5c4fa3a

tomaszhanaj force-pushed the feature/AAE-29424-screens branch from d542920 to 5c4fa3a Compare December 18, 2024 12:01

[AAE-29424] added self closing tags

254aadf

tomaszhanaj merged commit bb036cb into develop Dec 18, 2024
18 checks passed

tomaszhanaj deleted the feature/AAE-29424-screens branch December 18, 2024 14:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AAE-29424 Screens #10499

AAE-29424 Screens #10499

tomaszhanaj commented Dec 16, 2024 •

edited

Loading

BSekula Dec 16, 2024

tomaszhanaj Dec 17, 2024

BSekula Dec 16, 2024

tomaszhanaj Dec 17, 2024

BSekula Dec 16, 2024

tomaszhanaj Dec 17, 2024

BSekula Dec 16, 2024

tomaszhanaj Dec 17, 2024

BSekula Dec 16, 2024

tomaszhanaj Dec 17, 2024

BSekula Dec 16, 2024

tomaszhanaj Dec 17, 2024

BSekula Dec 16, 2024

tomaszhanaj Dec 17, 2024

BSekula Dec 16, 2024

tomaszhanaj Dec 17, 2024

BSekula Dec 16, 2024

tomaszhanaj Dec 17, 2024

BSekula Dec 16, 2024

tomaszhanaj Dec 17, 2024

BSekula commented Dec 16, 2024

sonarqubecloud bot commented Dec 18, 2024

	const componentType = this.screenRenderingService.resolveComponentType(this.screenComponent);
	const componentType = this.screenRenderingService.resolveComponentType({ type: this.screenId });

		@@ -0,0 +1,37 @@
		<div class="adf-task-form-cloud-container" >
		<adf-cloud-form #adfCloudForm

	type TaskTypesType = (typeof TaskTypes)[keyof typeof TaskTypes];
	type TaskTypesType = typeof TaskTypes[keyof typeof TaskTypes];

AAE-29424 Screens #10499

AAE-29424 Screens #10499

Conversation

tomaszhanaj commented Dec 16, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BSekula commented Dec 16, 2024

sonarqubecloud bot commented Dec 18, 2024

Quality Gate passed

tomaszhanaj commented Dec 16, 2024 •

edited

Loading